Skip to content

Conversation

@dwalluck
Copy link
Contributor

  • Fix potential null pointers
  • Use String::replace() instead of replaceAll for single characters
  • Use isEmpty which can be more efficient
  • Remove exception which is not thrown
  • Make StandardTypes constructor private

@dwalluck
Copy link
Contributor Author

In my opinion, StandardTypes should be an enum and not a utility class if you are willing to break compatibility.

@dwalluck dwalluck force-pushed the package-url branch 2 times, most recently from 8ff2a38 to cae12c5 Compare February 27, 2025 18:19
* Fix potential null pointers
* Use `String::replace()` instead of `replaceAll` for single characters
* Use `isEmpty` which can be more efficient
* Remove exception which is not thrown
@jeremylong jeremylong changed the title Fix some issues with PackageURL fix: correct issues with PackageURL Mar 11, 2025
Copy link
Collaborator

@jeremylong jeremylong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeremylong jeremylong merged commit 62ac909 into package-url:master Mar 11, 2025
2 checks passed
@dwalluck dwalluck deleted the package-url branch April 15, 2025 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants